Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #23629 to 7.x: [libbeat] Expose the new Sarama flag 'DisablePAFXFAST' in the Kafka output #23665

Merged
merged 6 commits into from
Jan 26, 2021
Merged

Cherry-pick #23629 to 7.x: [libbeat] Expose the new Sarama flag 'DisablePAFXFAST' in the Kafka output #23665

merged 6 commits into from
Jan 26, 2021

Conversation

faec
Copy link
Contributor

@faec faec commented Jan 25, 2021 •
edited by zube bot
Loading

Cherry-pick of PR #23629 to 7.x branch. Original message:

What does this PR do?

This PR adds the new flag enable_krb5_fast to the Kafka output, which (un)sets the DisablePAFXFAST flag added in Sarama 1.27.0. FAST authentication via Sarama can conflict with Active Directory, so this flag is off by default.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@faec faec requested review from a team as code owners January 25, 2021 18:26
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 25, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 25, 2021
@faec faec requested a review from urso January 25, 2021 18:27
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 25, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23665 updated

    • Start Time: 2021-01-26T19:54:02.192+0000

  • Duration: 49 min 59 sec

  • Commit: b06709b

Test stats 🧪

Test Results
Failed 0
Passed 17304
Skipped 1373
Total 18677

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 17304
Skipped 1373
Total 18677

@faec
Copy link
Contributor Author

faec commented Jan 25, 2021

...the automation thinks this is "most likely a genuine test failure," but it's definitely not related to this change (failure link). Not sure yet if the failure is consistent.

@faec
Copy link
Contributor Author

faec commented Jan 25, 2021

After retrying with no changes to the PR or base branch, the failing test passes, but now a different test fails.

@faec
Copy link
Contributor Author

faec commented Jan 26, 2021

After syncing to the latest 7.x branch (albeit with no obviously relevant changes), the preceding tests all pass, but now a new one fails.

full run
specific failure

auditbeat-windows-windows-2019
auditbeat/module/file_integrity.TestActions

=== RUN   TestActions
    metricset_test.go:164: 
        	Error Trace:	metricset_test.go:164
        	Error:      	[]string{"deleted"} does not contain "updated"
        	Test:       	TestActions
--- FAIL: TestActions (0.05s)

@faec
Copy link
Contributor Author

faec commented Jan 26, 2021

Hopefully final update: after running the tests again, with no further changes to the PR or base branch, they finally all passed.

@faec faec merged commit e8ade83 into elastic:7.x Jan 26, 2021
@faec faec deleted the backport_23629_7.x branch January 26, 2021 21:00
@zube zube bot removed the [zube]: Done label Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urso urso urso approved these changes

Assignees
No one assigned
Labels
backport Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@faec @elasticmachine @urso